]> dgit.raspbian.org Git - gnome-shell.git/commit
allView, frequentView: Only create icons when necessary
authorGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Thu, 21 Nov 2019 20:57:17 +0000 (17:57 -0300)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Thu, 21 Nov 2019 22:28:46 +0000 (22:28 +0000)
commit910037f014355ee9680c45f82a4aac2891c4074f
tree50a470c6bdb3ad437cff7d5b613a8ecc947c0b08
parentacaa9f7f77361a87a7fcb79f8a37e7eebb7a9f34
allView, frequentView: Only create icons when necessary

The views (AllView and FrequentView) build a list of all applications
they contain. BaseView then diffs between what's currently added, and
what needs to be added, and removed.

This approach has a problem though: creating an AppIcon or a FolderIcon
connects to various signals, and we confuse the garbage collector.

When building the list of applications, instead of always creating new
icons, try to use already existing icons first.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1610
Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1694
js/ui/appDisplay.js